Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call get_future_imports when needed. #3135

Merged
merged 1 commit into from Jun 23, 2022
Merged

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Jun 23, 2022

Description

This is just a tiny optimization to skip unnecessary calls to get_future_imports.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@ichard26 ichard26 added skip news Pull requests that don't need a changelog entry. C: performance Black is too slow. Or too fast. labels Jun 23, 2022
@github-actions
Copy link

github-actions bot commented Jun 23, 2022

diff-shades reports zero changes comparing this PR (a41d673) to main (6463fb8).


What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit fa6caa6 into psf:main Jun 23, 2022
41 of 42 checks passed
@JelleZijlstra
Copy link
Collaborator

JelleZijlstra commented Jun 23, 2022

Thanks!

@yilei yilei deleted the opt branch Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: performance Black is too slow. Or too fast. skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants