Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preview style docs to include recent changes #3136

Merged
merged 5 commits into from Jun 27, 2022

Conversation

felix-hilden
Copy link
Collaborator

@felix-hilden felix-hilden commented Jun 24, 2022

Description

I went through the commits after the last release to see are the style docs outdated, and here's an update for #2926, #2990, #2991 and #3035. Conveniently, they share a theme, so I wrote quite a terse doc and made another section shorter too. Feel free to elaborate if you see the need, I'll have to catch a train now 馃槃

Checklist - did you ...

  • N/A Add a CHANGELOG entry if necessary?
  • N/A Add / update tests if necessary?
  • Add new / update outdated documentation?

@felix-hilden felix-hilden added the skip news Pull requests that don't need a changelog entry. label Jun 24, 2022
@JelleZijlstra JelleZijlstra requested a review from ichard26 Jun 24, 2022
felix-hilden and others added 2 commits Jun 24, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Copy link
Collaborator

@ichard26 ichard26 left a comment

Thanks for tackling this! I think you may have gone overboard with the terseness though :)

docs/the_black_code_style/future_style.md Show resolved Hide resolved
docs/the_black_code_style/future_style.md Show resolved Hide resolved
docs/the_black_code_style/future_style.md Outdated Show resolved Hide resolved
@felix-hilden felix-hilden requested a review from ichard26 Jun 26, 2022
Copy link
Collaborator

@ichard26 ichard26 left a comment

It doesn't flow very nicely, but I can't think of a way to improve it so it's fine. I'd appreciate a re-review from Jelle though.

@ichard26 ichard26 requested a review from JelleZijlstra Jun 27, 2022
@ichard26 ichard26 changed the title Update preview docs Update preview style docs to include recent changes Jun 27, 2022
@felix-hilden
Copy link
Collaborator Author

felix-hilden commented Jun 27, 2022

This is a pseudo-approval for Rich's changes!

@ichard26 ichard26 merged commit eb5d175 into psf:main Jun 27, 2022
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants