Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap concatenated strings used as function args in parens. #3307

merged 7 commits into from Oct 27, 2022


Copy link

@yilei yilei commented Oct 3, 2022


This implements #3292.

I have only heard one 馃憤 from @felix-hilden. But I think it's also easier to decide after seeing the formatting changes introduced by this PR, thus I'm sending it now so we can visualize the diffs.

Checklist - did you ...

  • Add an entry in if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Copy link

github-actions bot commented Oct 3, 2022

diff-shades results comparing this PR (5f4e810) to main (09d4acd). The full diff is available in the logs under the "Generate HTML diff report" step.

鈺攢鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹 Summary 鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈹鈺
鈹 17 projects & 529 files changed / 39 015 changes [+23 421/-15 594] 鈹
鈹                                                                    鈹
鈹 ... out of 2 329 053 lines, 10 713 files & 23 projects             鈹

Differences found.

What is this? | Workflow run | diff-shades documentation

Copy link

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff-shades output I'm still a bit nervous whether this is a net positive, since it does often feel like it's adding unnecessary lines. But I guess that's what we have a preview style for. Outdated Show resolved Hide resolved
src/black/ Outdated Show resolved Hide resolved
Copy link
Contributor Author

yilei commented Oct 26, 2022

Updated, please take another look. Thanks Jelle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants