Vim plugin: allow using system black rather than virtualenv #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-hilden
reviewed
Oct 7, 2022
Collaborator
felix-hilden
left a comment
felix-hilden
left a comment
There was a problem hiding this comment.
Thanks for the PR, some comments below!
Provide a configuration parameter to the Vim plugin which will allow the plugin to skip setting up a virtualenv. This is useful when there is a system installation of black (e.g. from a Linux distribution) which the user prefers to use. Using a virtualenv remains the default. - Fixes #3308
felix-hilden
reviewed
Oct 7, 2022
felix-hilden
approved these changes
Oct 7, 2022
Contributor
Author
|
@felix-hilden (or anyone) is there anything I need to do to get this PR merged? So far, I don't think there are any objections. Thanks, |
cooperlees
approved these changes
Oct 27, 2022
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Looks fine to me, felix approved, but I have very little vim plugin skill ... #blindMerge
Contributor
Author
|
Thank you. |
|
To use this, add this to your let g:black_use_virtualenv = 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a configuration parameter to the Vim plugin which will allow the plugin to skip setting up a virtualenv. This is useful when there is a system installation of black (e.g. from a Linux distribution) which the user prefers to use.
Using a virtualenv remains the default.
Description
I have several reasons why using a virtualenv is undesirable to me. I have listed them in the following feature request.
Fixes: #3308
Checklist - did you ...
CHANGES.mdif necessary?Thanks,
Corey