Skip to content

ci: harden workflows - #345

Merged
frostming merged 2 commits into
masterfrom
ww/zizmor
Dec 17, 2024
Merged

ci: harden workflows#345
frostming merged 2 commits into
masterfrom
ww/zizmor

Conversation

@woodruffw

Copy link
Copy Markdown
Member

This hash-pins all of our workflows and fixes some (low-impact) zizmor findings.

It also adds a zizmor workflow that'll run on pushes and PRs to prevent issues from sneaking in.

This hash-pins all of our workflows
and fixes some (low-impact) zizmor findings.

It also adds a `zizmor` workflow that'll run
on pushes and PRs to prevent issues from sneaking in.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
woodruffw requested a review from frostming December 16, 2024 22:42
@woodruffw woodruffw self-assigned this Dec 16, 2024
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment thread .github/workflows/zizmor.yml Fixed
See stacklok/frizbee#206.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw

Copy link
Copy Markdown
Member Author

CC @frostming for approval (since this is my tool + we should really have two-person signoffs here, but I don't have this ability to enable them 😅)

@frostming
frostming merged commit 5200de8 into master Dec 17, 2024
@frostming
frostming deleted the ww/zizmor branch December 17, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants