Comparing changes
Open a pull request
* Continuity: Google App Engine
Clarify that PreparedRequests should not be manually created
* Docs: list CURL_CA_BUNDLE as supported
Update misleading text about python support
This follows instructions from the Apache Foundation. It also ensures that the license will be correctly detected by license scanning tools. Note that by adding a NOTICE file triggers Section 4.d of the license, which is usually intended by users of the license. The text that was in the LICENSE file before this change is intended (by the authors of the license) to be used as a file header, and not as a full license notice for a project, but it is commonly used this way, so I would of course understand if this change is rejected.
Apply the Apache-2.0 license correctly
replaced reference to requests-async with httpx the replacement project
Add official Python 3.8 support on Appveyor
Remove proposed/3.0.0 branch, only ever run against Python sans matrix option
Create codeql-analysis.yml
a small typo was corrected.
small typo corrected.
Respect the NETRC environment variable
Remove reference to development philosophy
Update advanced.rst
`ubuntu-latest` points to 18.04 and will soon flip to 20.04. However tests currently fail on 20.04, so let's explicitly pin to 18.04 for now.
Pin GHA to Ubuntu 18.04
…ore user friendly way
…s in a more user friendly way" This reverts commit 4b66260
…pe is set to application/json, following RFC 4627. fixes #5667
updated `get_encoding_from_headers` to return utf-8 if the content type is set to application/json
Proxy related doc updates
PSF relaunched new sponsorship program and the URL has changed.
Upgrade to chardet 4.x
Showing you all comments on commits in this comparison.
This comment has been minimized.
This comment has been minimized.
|
The |
This comment has been minimized.
This comment has been minimized.
|
As the contributor I don't know enough about the library to weigh in, but the reason for this PR was based on #5667. Can you take a look and see if there is another solution that will solve that issue? In short, the issue is that the I'm more than happy to create a different PR for a quick review based on what you would like. To quickly reproduce the issue in #5667, you can run the following code:
I would expect the 2nd print statement to be identical to the first -- i.e. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for bringing this to our attention, @k0ssi! It sounds like this needs some more work. We may need to move the |
This comment has been minimized.
This comment has been minimized.
|
Unfortunately I dont have much time to take a closer look at the this at the moment. I'll have a look at it on the weekend and then get back to you next week. At the moment we first have to figure out what causes the issue @jjmaldonis tells. At first glance this looks to me as a encoding error within text() not json() @jjmaldonis by setting an charset within get_encoding_from_headers function which is used to build the response there is no guessing while using .json() since charset is already set. Since there is no guarantee everyone is using 'utf-8' we cannot simply assume it is. |
This file was deleted.