-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests 2.18.0 breaks docker-py #4160
Comments
|
Well this is extremely perplexing. It seems like the fix that landed in 2.17.3 to resolve the packages problem is not present in 2.18. I have no idea what has happened here, because none of the diff between the 2.17.3 tag and the 2.18 tag contains anything that looks like it'd affect this. |
|
Ok, got it. This is a problem with having old data left behind in my copy of the repo, which means when I did the release we broke the wheel. I'm sorry about that, I'll push out a v2.18.1 shortly. |
|
2.18.1 has been released that should fix this problem. There's no need for code changes: this was purely an issue with my on-disk copy of the code. Sorry about that! |
|
that fixes the issue. thanks for quick turnaround |
|
I still have this problem.... my versions are: rancher@RancherOS1_SRV:~$ pip freeze |
|
Same here with requests 2.18.4, fixed with 2.18.1 |
|
Same ! got this problem with 2.18.4 and fixed with 2.18.1 ! |
|
@oussemos @titilambert, could you please confirm that 2.18.1 is the latest version that works for you? (i.e. 2.18.2 and 2.18.3 don't work either?) |
|
Same issue with 2.18.4 |
|
With Docker Compose |
|
@butla same here. 2.15.1 is only version that works with docker compose 1.17.1 |
|
Updated pip and saw this error |
Summary.
Got bitten right after this new requests version released. When I run with docker-py, it is fine before. now it is complaining :
Error while fetching server API version: Timeout value connect was Timeout(connect=60, read=60, total=None), but it must be an int, float or None.
Expected Result
backward compatibility should be maintained from requests module
What you expected.
Actual Result
python
Python 2.7.5 (default, Nov 6 2016, 00:28:07)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Reproduction Steps
pip install requests==2.17.3
Collecting requests==2.17.3
Using cached requests-2.17.3-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): chardet<3.1.0,>=3.0.2 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): certifi>=2017.4.17 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): idna<2.6,>=2.5 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): urllib3<1.22,>=1.21.1 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Installing collected packages: requests
Found existing installation: requests 2.18.0
Uninstalling requests-2.18.0:
Successfully uninstalled requests-2.18.0
Successfully installed requests-2.17.3
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
[root@bootserver-do-not-delete ~]# python
Python 2.7.5 (default, Nov 6 2016, 00:28:07)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
this works
System Information
$ python -m requests.help
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "2.7.5"
},
"platform": {
"release": "3.10.0-514.21.1.el7.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.18.0"
},
"system_ssl": {
"version": "1000105f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
The text was updated successfully, but these errors were encountered: