fix #2247 #2249
fix #2247 #2249
Conversation
This looks right, but it's hard for me to know because URLs are a crazy mess. I'll let @sigmavirus24 review this, he knows URLs better than I do. |
So if we used a better (read: less forgiving) URL parser library we wouldn't need to split on
And
|
@@ -17,7 +17,7 @@ | |||
from .packages.urllib3.util import Timeout as TimeoutSauce | |||
from .compat import urlparse, basestring, urldefrag |
sigmavirus24
Sep 26, 2014
Contributor
Please remove the import of urldefrag
here.
Please remove the import of urldefrag
here.
+∞. I think it would be best to have URL objects that are immutable and an API like URL.replace(userinfo=None, fragment=None) |
@t-8ch that's roughly |
@sigmavirus24 Please open the specific issue with urllib3's url parser, no need to be backhanded. :) |
Sorry @shazow, it wasn't meant to be back handed. I'll pull together the list of things the object is missing and make an issue with it tonight. |
Thanks. :) |
What's the status of this? |
We have to pass urllib3 the url without the authentication information,
else it will be parsed by httplib as a netloc and included in the request line
and Host header