Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap url parsing exceptions from urllib3's PoolManager #4765

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Aug 11, 2018

This should address #4746 by catching and wrapping all LocationValueErrors and rewrapping them under the Requests namespace as InvalidURL.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 11, 2018

Codecov Report

Merging #4765 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4765      +/-   ##
==========================================
+ Coverage   66.77%   66.79%   +0.02%     
==========================================
  Files          15       15              
  Lines        1568     1572       +4     
==========================================
+ Hits         1047     1050       +3     
- Misses        521      522       +1
Impacted Files Coverage Δ
requests/adapters.py 70.27% <80%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f20b7d...f3ec42f. Read the comment docs.

@nateprewitt nateprewitt force-pushed the encapsulate_urllib3_exc branch from 227eac2 to f3ec42f Sep 30, 2018
@nateprewitt nateprewitt force-pushed the encapsulate_urllib3_exc branch from f3ec42f to bbdbcc8 Oct 1, 2018
@nateprewitt nateprewitt merged commit a6cd380 into master Oct 1, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nateprewitt nateprewitt deleted the encapsulate_urllib3_exc branch Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants