Make the build reproducible #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] I noticed that psi could not be built reproducibly. This is due to using CMake's TIMESTAMP feature without specifying a timezone. This means that, even if SOURCE_DATE_EPOCH is present, the value (and thus the binary) will vary depending on the build machine's timezone setting. I originally filed this in Debian as bug #1017473 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1017473
Ri0n
approved these changes
Aug 16, 2022
Vitozz
approved these changes
Aug 16, 2022
|
Hi @lamby. |
|
Not quite - since CMake 3.8.0, CMake will use the SOURCE_DATE_EPOCH environment variable if it exists, so ensuring the output is in UTC will indeed actually make psi reproducible from day to day. |
|
I see. Thanks @lamby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that psi could not be built reproducibly.
This is due to using CMake's
TIMESTAMPfeature without specifying a timezone. This means that, even ifSOURCE_DATE_EPOCHis present, the value (and thus the binary) will vary depending on the build machine's timezone setting.(I originally filed this in Debian as bug #1017473.)