Join GitHub today
Cubeprop improvements #1138
Added a couple of new features to cubeprop. The functionality seems to work, but the PR is rather unpolished. An illustration of me while writing this PR can be found here:
Notable points that this PR has either accomplished or will accomplish.
@fevangelista I am absolutely clueless about CAS methods, so I'd rather not go there.
@TermeHansen If I understand correctly, you'd like a
Thanks for the ping – I had missed that there were new commits. Thanks for the new functionality, lgtm. At some point, it'd be good to add a test. There's a
compare_cubes function, so it's not as formidable as it sounds. I won't merge immediately, in case @dgasmith wanted to follow up on his comments.