New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON CLI patch #1369

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@dgasmith
Member

dgasmith commented Nov 25, 2018

Description

Ensures JSON is written back to file when called from CLI. Not entirely sure of a good way to test this however to ensure that it is not broken again without a fairly involved script.

Status

  • Ready for review
  • Ready for merge

dgasmith added some commits Nov 25, 2018

@dgasmith dgasmith added the bug label Nov 25, 2018

@dgasmith dgasmith added this to the Psi4 1.3 milestone Nov 25, 2018

@loriab

loriab approved these changes Nov 25, 2018

Test through pytest, perhaps. I think optking has a prototype since they weren’t using dicts for a while.

@robertodr robertodr merged commit bced6b3 into psi4:master Nov 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dgasmith dgasmith referenced this pull request Dec 6, 2018

Open

Psi4 1.3 Release Notes #1406

@dgasmith dgasmith deleted the dgasmith:json branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment