Get rid of manual memory management in petitelist #3026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
approved these changes
Aug 14, 2023
Contributor
JonathonMisiewicz
left a comment
JonathonMisiewicz
left a comment
There was a problem hiding this comment.
The merge conflict needs to be fixed, but LGTM otherwise.
susilehtola
force-pushed
the
petitelist
branch
from
6e7a53a to
40ee1d6
Compare
loriab
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup to libmints/petitelist to remove manual memory management in favor of
std::vector.Some of the code was not really clear (use of both
lenandlengthin some of the SO objects).User API & Changelog headlines
Dev notes & details
Questions
Checklist
Status