Cd sherrill patch 3 #3035
Merged
Cd sherrill patch 3 #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain that the old scaling by the ratio of exact exchange vs S^2 approximated exchange for the single-exchange-approximated terms is no longer done by default as of 2016, and cite a paper explaining why.
Trivial edit verb tense
Fix typo on referencing a reference we already have in the bibliography
davpoolechem
approved these changes
Aug 28, 2023
susilehtola
approved these changes
Aug 28, 2023
loriab
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the manual to clarify that exchange-scaling of S^2-approximated terms
is no longer done by default, and explain why (cite 2013 Jansen paper)
This is just a quick text edit of the manual, nothing else has changed.
Status