ROHF guess fix #570
Merged
ROHF guess fix #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
force-pushed
the
rohf_guess
branch
2 times, most recently
from
5a47193
to
997b132
Compare
andysim
reviewed
Jan 14, 2017
andysim
approved these changes
Jan 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that the
Ct_array is built when using initial guesses with ROHF Wavefunctions. Thereby fixingGUESS READfor ROHF Wavefunctions.As a note this still wont quite work for CUHF as we do not have a full orthogonal basis available. However, it works much better than for ROHF and generally stays in the same minima.
Status