Logging improvements

[LourensVeen]

I'm using QCG-PilotJob as a library, and when I do so my program spews a lot of log messages from QCG-PJ on the console. I'd like to redirect them to a separate log file. Unfortunately:

• All log messages are sent to the root logger, rather than to a module specific logger,
• There are print statements in the code, which cannot be controlled from the logging subsystem, and
• QCG-PJ sets the root logger's log level, overriding my own settings.

I'd like to:

• modify the log statements to follow the scheme from Python's Advanced Logging Tutorial, so that the log output can be configured cleanly,
• replace the print statements by log statements (at INFO-level?),
• have QCG-PJ only set the root logger's log level when run in command line mode, but not when used as a library.

I'm going to try to have a new version of MUSCLE3 out with the next VECMAtk release in January, and I realise this is soon, so I'm offering to submit a pull request with the above changes, if you agree that it's a good idea?

[pkopta]

Yes, you are right - the logging in the QCG-PilotJob is a bit messy. If you have a ready pull request I will be glad if you will push it to the repo.

[LourensVeen]

I've made a PR for this. It's slightly different than what I wrote above, logging is now done using module-specific loggers, and where QCGPJ used the root logger it now uses the qcg.pilotjob logger instead (including for determining whether we're in debug mode). In my test program I now no longer get messages on the console.

[LourensVeen]

Thanks for merging! Do you normally close issues when they've been implemented, or when the fix has been released?

[pkopta]

I always thought that issue should be automatically closed after merging pull request (thanks to 'close #' in comment) but apparently this is not true.

[LourensVeen]

Interesting! I had a quick look at the documentation, and it seems that this only works if the PR is merged into the default branch. For this repo, that's master, while this PR was merged into develop. So that would explain.

I normally have my default branch set to develop, but that also has disadvantages, like people seeing the README for the latest in-development version rather than for the latest release. I guess we'll have to use the close button then :-).