Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, migrate any urllib2_kerberos code to urllib-gssapi.
Similar caveats to psss/python-nitrate#8 apply:
In Both here and in python-nitrate, you only perform one round of a SPNEGO handshake. This means that not all SPNEGO connections will complete - you never validate the server tokens, so mutual auth will always fail. I'm a bit surprised this works at all. Using requests-gssapi or urllib-gssapi will handle this problem for you.