Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to python-gssapi #147

Merged
merged 1 commit into from Nov 23, 2018
Merged

Port to python-gssapi #147

merged 1 commit into from Nov 23, 2018

Conversation

frozencemetery
Copy link
Contributor

@frozencemetery frozencemetery commented Feb 19, 2018

As part of this, migrate any urllib2_kerberos code to urllib-gssapi.

Similar caveats to psss/python-nitrate#8 apply:

In Both here and in python-nitrate, you only perform one round of a SPNEGO handshake. This means that not all SPNEGO connections will complete - you never validate the server tokens, so mutual auth will always fail. I'm a bit surprised this works at all. Using requests-gssapi or urllib-gssapi will handle this problem for you.

As part of this, migrate any urllib2_kerberos code to urllib-gssapi.
@psss psss self-assigned this Nov 23, 2018
@psss
Copy link
Owner

psss commented Nov 23, 2018

Thanks for providing the patch. The test suite should now be much better. Currently there does not seem to be python-urllib2-gssapi packaged for epel7. Could we use python2-requests-gssapi instead?

@psss psss merged commit 776ae1d into psss:master Nov 23, 2018
@psss
Copy link
Owner

psss commented Nov 23, 2018

I was able to make this working with requests_gssapi, but the mutual authentication has to be disabled for the Jira instace I test against. Any ideas for improvement welcome :) Current state merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants