Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom xmlrpc endpoint for MoinMoin wiki #242

Merged
merged 1 commit into from Apr 19, 2021
Merged

Support custom xmlrpc endpoint for MoinMoin wiki #242

merged 1 commit into from Apr 19, 2021

Conversation

psss
Copy link
Owner

@psss psss commented Apr 9, 2021

Resolves #239.

@psss
Copy link
Owner Author

psss commented Apr 9, 2021

This seems to be working fine with the new RPC2 endpoint provided by @mrc0mmand. Example config:

[wiki]
type = wiki
api = RPC2
wiki test = http://the.wiki.server/

@AsciiWolf, @optak, please give it a try and let me know if it works for you. Thanks.

@psss psss requested a review from optak April 9, 2021 15:40
@psss psss added this to the 0.18 milestone Apr 9, 2021
@psss psss self-assigned this Apr 9, 2021
@AsciiWolf
Copy link

@psss It seems that wiki.brq does not support RPC2 so I had to comment it out in did config, however it works fine with wiki.test. Thanks! :-)

@mrc0mmand
Copy link

@psss It seems that wiki.brq does not support RPC2 so I had to comment it out in did config, however it works fine with wiki.test. Thanks! :-)

Yeah, I wasn't sure if this will be the final solution, so I haven't reconfigured the BRQ wiki yet. Will do that next week.

@psss
Copy link
Owner Author

psss commented Apr 12, 2021

it works fine with wiki.test

Good to hear! Thanks for the verification.

@psss
Copy link
Owner Author

psss commented Apr 12, 2021

I haven't reconfigured the BRQ wiki yet. Will do that next week.

Nice, thanks a lot!

@optak
Copy link
Collaborator

optak commented Apr 19, 2021

LGTM

@psss
Copy link
Owner Author

psss commented Apr 19, 2021

Thanks for the review. Merging.

@psss psss merged commit 25c0d71 into master Apr 19, 2021
@psss psss deleted the wiki-api branch April 19, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wiki] not working with python-3.9
4 participants