Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to modify TCP checksum. #58

Closed
GoogleCodeExporter opened this issue Jul 2, 2015 · 7 comments
Closed

Impossible to modify TCP checksum. #58

GoogleCodeExporter opened this issue Jul 2, 2015 · 7 comments
Labels

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

What steps will reproduce the problem?
1. Edit on a stream
2. Modify a TCP checksum
3. Clock OK and Apply
4. Open the stream

What is the expected output? What do you see instead?

The TCP checksum is not modified.

What version and revision of the product are you using (available in the
About dialog)? On what operating system?

Build from latest mercurial.

Please provide any additional information below.

The problem is that the string format is not well interpreted when read back: 
it seems not possible to convert the formatted string to an integer by using 
the string function.

I attach to the ticket a patch that fix the issue. It is not meant to be 
applied but show where the problem is.

Original issue reported on code.google.com by eric.leb...@gmail.com on 21 Dec 2011 at 4:50

Attachments:

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

Original comment by pstav...@gmail.com on 22 Dec 2011 at 1:59

  • Changed state: Accepted
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

This issue was closed by revision 807e85df64ed.

Original comment by pstav...@gmail.com on 22 Dec 2011 at 2:00

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

@eric: Thanks for reporting this issue. I have fixed it in the repo - please 
pull and check.

Original comment by pstav...@gmail.com on 22 Dec 2011 at 2:01

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

I've just updated, build and installed ostinato but it does not work. I'm sure 
the update has been made because I don't see any trace of my POC patch.

Original comment by eric.leb...@gmail.com on 22 Dec 2011 at 2:33

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

@eric: Please recheck. It works fine for me . Make sure that your code is 
updated as per the following patch and you have built it and are running the 
correct binary.

http://code.google.com/p/ostinato/source/diff?spec=svn807e85df64ed036584dab21676
b457ea690f1caf&old=f99d5b97f3d9b2e9837204af9f2c9327cb66716c&r=807e85df64ed036584
dab21676b457ea690f1caf&format=unidiff&path=%2Fcommon%2Ftcp.cpp



Make sure 

Original comment by pstav...@gmail.com on 23 Dec 2011 at 1:50

  • Changed state: Reviewed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

Oups my fault, I get confused with mercurial pull command which do not work 
like git pull. Issue fixed! I'm really sorry for the false alarm...

Original comment by eric.leb...@gmail.com on 23 Dec 2011 at 4:07

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Jul 2, 2015

Ah, I guess you didn't do a "hg update" to update your working copy!

Closing the issue.

Original comment by pstav...@gmail.com on 23 Dec 2011 at 4:29

  • Changed state: Verified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.