Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to serialize replies and events #729

Closed
notgull opened this issue Jun 28, 2022 · 1 comment · Fixed by #735
Closed

Add ability to serialize replies and events #729

notgull opened this issue Jun 28, 2022 · 1 comment · Fixed by #735

Comments

@notgull
Copy link
Collaborator

notgull commented Jun 28, 2022

I was writing a test harness for breadx, where I serialize the requests it's supposed to send into a byte stream and then compares it to make sure it's outputting the right stuff. I'd also like to make it so I could feed the test harness replies, events and errors. However, to do this, I would need to be able to serialize these items. At the moment, replies and events do not implement Serialize.

Is there any particular reason why this is? If not, I'll go ahead and write a PR that adds these impls to these objects.

@psychon
Copy link
Owner

psychon commented Jun 30, 2022

Is there any particular reason why this is?

I cannot think of any. I am sure that somewhere there was already some talk about it, but I do not know any details. Perhaps there was something about the special case of "most" events being 32 bytes? Dunno...

So... feel free & remember that FDs make everything complicated. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants