Skip to content

Commit

Permalink
BF: Movie Compon with stopTime=None was trying to calculate stop time
Browse files Browse the repository at this point in the history
It led to undefine being added to the frameRemains calculation.
Was caused by accidentally altering the contents of the movie params
while trying to convert None->undefined

Don't convert movie.params['stopTime'].val to be undefined!

fixes gh-3182
  • Loading branch information
peircej committed Oct 22, 2020
1 parent 04fb931 commit 0b4ddcf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion psychopy/experiment/components/movie/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from __future__ import absolute_import, print_function

from os import path
import copy
from psychopy import logging
from psychopy.experiment.components import BaseVisualComponent, getInitVals, Param, _translate

Expand Down Expand Up @@ -150,7 +151,7 @@ def _writeCreationCodeJS(self, buff, useInits):
if useInits:
inits = getInitVals(self.params)
else:
inits = self.params
inits = copy.deepcopy(self.params)

noAudio = '{}'.format(inits['No audio'].val).lower()
loop = '{}'.format(inits['loop'].val).lower()
Expand Down

0 comments on commit 0b4ddcf

Please sign in to comment.