Skip to content

Commit 40bbfe1

Browse files
Toddpeircej
authored andcommitted
BF: PsychoPy constants should be valid values when doing validation on code snippets, partially fixes #3320
1 parent 4640e37 commit 40bbfe1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

psychopy/app/builder/validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ def _highlightParamVal(parent, error=False):
240240

241241
for newName in names:
242242
namespace = parent.frame.exp.namespace
243-
if newName in namespace.user or newName in namespace.builder:
243+
if newName in [*namespace.user, *namespace.builder, *namespace.constants]:
244244
continue
245245
used = namespace.exists(newName)
246246
sameAsOldName = bool(newName == parent.params['name'].val)

psychopy/experiment/exports.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ def __init__(self, exp):
147147
# noinspection PyUnresolvedReferences
148148
self.keywords = keyword.kwlist + dir(__builtins__)
149149
# these are based on a partial test, known to be incomplete:
150-
self.psychopy = psychopy.__all__ + ['psychopy', 'os'] + dir(constants)
150+
self.psychopy = psychopy.__all__ + ['psychopy', 'os']
151+
self.constants = dir(constants)
151152
self.builder = ['KeyResponse', 'keyboard', 'buttons',
152153
'continueRoutine', 'expInfo', 'expName', 'thisExp',
153154
'filename', 'logFile', 'paramName',

0 commit comments

Comments
 (0)