Skip to content

Commit 4592876

Browse files
committed
BF: Copied routines skip the builder rename routine method, so do comp updates in base routine method
1 parent 25fb102 commit 4592876

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

psychopy/app/builder/builder.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,8 +1323,6 @@ def renameRoutine(self, name, event=None):
13231323
# Swap old with new names
13241324
self.exp.routines[oldName].name = name
13251325
self.exp.routines[name] = self.exp.routines.pop(oldName)
1326-
for comp in self.exp.routines[name]:
1327-
comp.parentName = name
13281326
self.exp.namespace.rename(oldName, name)
13291327
self.routinePanel.renameRoutinePage(currentRoutineIndex, name)
13301328
self.addToUndoStack("`RENAME Routine `%s`" % oldName)

psychopy/experiment/routines/_base.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,9 @@ def name(self):
259259
@name.setter
260260
def name(self, name):
261261
self.params['name'] = name
262+
# Update references in components
263+
for comp in self:
264+
comp.parentName = name
262265

263266
def integrityCheck(self):
264267
"""Run tests on self and on all the Components inside"""

0 commit comments

Comments
 (0)