Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonsensical column added to data output on early termination #1115

Closed
m-macaskill opened this issue Feb 17, 2016 · 2 comments
Closed

Nonsensical column added to data output on early termination #1115

m-macaskill opened this issue Feb 17, 2016 · 2 comments

Comments

@m-macaskill
Copy link
Contributor

@m-macaskill m-macaskill commented Feb 17, 2016

In a Builder experiment with nested loops, terminating the experiment early via the escape key results in a nonsensical column being inserted into the .csv data output file.
e.g. if the outer loop is named trials_2, then following early termination, a column will be added after the trials_2.thisIndex column, labelled trials_2.thisTrial, with cell values of None. i.e. it seems that the entire thisTrial object is being passed to be saved in the data in this situation. This makes data files following early termination have one extra column than data files from regular sessions.

@jeremygray
Copy link
Member

@jeremygray jeremygray commented Feb 17, 2016

._getLoopInfo() has a couple lines that appear to be responsible. If I comment them out I don't see the odd columns when ending early via escape.

            else:
                names.append(name + '.thisTrial')
                vals.append(trial)

At first glance, the data output seems normal when NOT using escape. Important to test more carefully (!).

@peircej
Copy link
Member

@peircej peircej commented Feb 18, 2016

I don't recall the point of that code. Maybe it's a pure unnecessary piece!

@peircej peircej closed this in 5a75f95 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.