Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner issues with file selection #3142

Closed
peircej opened this issue Sep 18, 2020 · 0 comments · Fixed by #3143
Closed

Runner issues with file selection #3142

peircej opened this issue Sep 18, 2020 · 0 comments · Fixed by #3143

Comments

@peircej
Copy link
Member

peircej commented Sep 18, 2020

Several buglets:

  • if you run a script and then, in Runner, move to a different item, then you can't ever get back to the Red Stop button (it gets disabled and never re-enabled when switching files). Fix so the red cross always kills the running process (only allowing 1 running script?) or track multiple processes (one per script?)
  • there seem to be some issues as well with the wrong script sometimes running or sometimes no script being selected (if file is in the list and you press run from Coder it sometimes fails to select the right script)
peircej added a commit to peircej/psychopy that referenced this issue Sep 18, 2020
@peircej
BF: Runner removed Stop btn if changed file selection
e028268 
fixes psychopyGH-3142

Also some reports of the wrong script running?

We now;
- track if the script process is running and use that to determine
  whether RunBtn should be enabled:
  just runBtn.Enable() during onSelectedItem if not running
- store a dict of entries for the ListCtrl rather than searching for
  the items (ListrCtrl FindItem is poor)
- don't hard-code the column numbers - what if we change them later?
@peircej peircej mentioned this issue Sep 18, 2020
Merged
peircej added a commit that referenced this issue Oct 22, 2020
@peircej
BF: Runner removed Stop btn if changed file selection
ac7bded 
fixes GH-3142

Also some reports of the wrong script running?

We now;
- track if the script process is running and use that to determine
  whether RunBtn should be enabled:
  just runBtn.Enable() during onSelectedItem if not running
- store a dict of entries for the ListCtrl rather than searching for
  the items (ListrCtrl FindItem is poor)
- don't hard-code the column numbers - what if we change them later?
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BF: Runner file selection issues peircej/psychopy
1 participant
@peircej