BF OSError: gamma.py can't find Carbon framework + better exception handling #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamma.py looks for the Carbon framework in the wrong place under OS X 10.11. The framework binary was moved from > /System/Library/Carbon.framework/Carbon to > /System/Library/Frameworks/Carbon.framework/Carbon Additionally gamma.py only calls the CGSetDisplayTransferByTable(,,,,). This function was moved to the CoreGraphics framework. Therefore, my suggestion is that gamma.py should try to load the CoreGraphics framework first and should use the Carbon framework only as fallback.
peircej
added a commit
that referenced
this pull request
Jan 22, 2016
BF OSError: gamma.py can't find Carbon framework + better exception handling
|
Thanks Pablo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gamma.py looks for the Carbon framework in the wrong place under OS X 10.11. The framework binary was moved from
/System/Library/Carbon.framework/Carbon
to
/System/Library/Frameworks/Carbon.framework/Carbon
Additionally gamma.py only calls the CGSetDisplayTransferByTable(,,,,). This function was moved to the CoreGraphics framework.
Therefore, my suggestion is that gamma.py should try to load the CoreGraphics framework first and should use the Carbon framework only as fallback.
I implemented better exception handling additionally to pull request #1084