Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: some errors with script compiling since PEP8 refactor #1253

Merged
merged 3 commits into from Sep 30, 2016

Conversation

@peircej
Copy link
Member

@peircej peircej commented Sep 30, 2016

No description provided.

peircej added 3 commits Sep 30, 2016
…ctor

@jeremygray @hoechenberger FYI for code that has multiple lines we have
to use
  `buff.writeIndentedLines(code)`
rather than
  `buff.writeIndented(code)`
so that indentation is used on each line
@peircej peircej merged commit 12c509a into psychopy:master Sep 30, 2016
0 of 2 checks passed
0 of 2 checks passed
code-quality/landscape Landscape is checking code quality
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jeremygray

This comment has been minimized.

Copy link
Member

@jeremygray jeremygray commented on dbfed25 Sep 30, 2016

Thanks for fixing. I would have expected the first one (line 197) to be ok with just writeIndented since it only ever has a single '\n' in the string named code.

This comment has been minimized.

Copy link
Member Author

@peircej peircej replied Sep 30, 2016

Ah, you're right on that, but it won't hurt. The new refactoring has obscured that it's a single line of comment ;-) I read it as a multiline string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants