Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
BF: Fix import and write issues with openpyxl #1276
referenced this pull request
Oct 15, 2016
Current coverage is 45.89% (diff: 66.66%)
@@ master #1276 diff @@ ========================================== Files 232 232 Lines 36819 36818 -1 Methods 0 0 Messages 0 0 Branches 5669 5670 +1 ========================================== - Hits 16899 16896 -3 - Misses 18374 18375 +1 - Partials 1546 1547 +1
Looks good to me! I would like to request one small change, though:
Ideally, to make it easier to assemble the change log and pick commits for the next release, the commit summary line would start with a descriptor specifying the type of change(s) introduced. In this case, it would be "BF: " for bug fix. So the commit summary line should read something like:
BF: Fix import and write issues with openpyxl
To change the commit message, you have to do an interactive rebase on the upstream master branch,
reword that commit, and force-push it back into your branch. If you don't have any clue what the heck I'm talking about (but are eager to learn), just contact me at firstname.lastname@example.org. If you don't feel like doing this weird stuff, we might as well just leave everything as it is now, and pull in the unmodified change set. ;)
Hehe no worries, I think we can just squash these commits.
The proper way to simply rename/change a commit, without creating a new one, is via interactive rebase, though. But never mind, all is good.
Maybe a little advice for the future: it's always a good idea to create a new, separate branch for fixes and new features, and not work on
... and the cycle continues
Maybe there's more elegant ways, but this is how I usually work. I don't use the command line anymore btw, there's great GUI tools available now. And my IDE also does most (actually, all) of that stuff anyway... (I'm using PyCharm)
At any rate, thank you very much for your contribution!