New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bf use version tag fetch #1301

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
4 participants
@kastman
Member

kastman commented Nov 9, 2016

When trying to use a valid tag from the versions repo that hadn't been downloaded as part of the initial versions repo checkout, the command to update the local versions repo was incorrect: git fetch github had two small bugs:

  1. Subprocess wasn't executing it in the VERSIONSDIR, giving the error:

    subprocess.CalledProcessError: Command '['git', 'fetch', 'github']' returned non-zero exit status 128

  2. git fetch wasn't automatically downloading tags, so although the commit for the new version was being pulled down, without the tag it could not be checked out as requested. Adding --tags pulls down tags correctly.

I also added some whitespace/readability changes to the rest of version_chooser.py from the yapf readability filter, which I've found to be pretty useful (the project's stated goal is to "end formatting holy wars").

@coveralls

This comment has been minimized.

coveralls commented Nov 9, 2016

Coverage Status

Coverage remained the same at 51.023% when pulling 8f68614 on kastman:BF_useVersionTagFetch into 62cb655 on psychopy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 9, 2016

Current coverage is 46.75% (diff: 40.00%)

Merging #1301 into master will not change coverage

@@             master      #1301   diff @@
==========================================
  Files           233        233          
  Lines         37144      37144          
  Methods           0          0          
  Messages          0          0          
  Branches       5733       5733          
==========================================
  Hits          17365      17365          
  Misses        18191      18191          
  Partials       1588       1588          

Powered by Codecov. Last update 62cb655...8f68614

@peircej peircej merged commit 9d3a6e6 into psychopy:master Nov 10, 2016

2 checks passed

code-quality/landscape Code quality remained the same
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment