Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing sys import call #1365

Merged
merged 1 commit into from Mar 8, 2017
Merged

Conversation

@frankgasking
Copy link
Contributor

@frankgasking frankgasking commented Mar 7, 2017

Hi Jon,

I noticed that RC 1.85.00 was crashing on any sound playback - both coder and builder. This was due to a missing sys import under sound/backend_pyo.py which i've added in.

However, I also noticed that even if you put "pygame" as the default, it crashes with the same error - and tries to use backend_pyo.py instead of backend_pygame.py. Not sure if this is an additional error, but couldn't spot anything obvious.

Best wishes,

Frank

@coveralls
Copy link

@coveralls coveralls commented Mar 7, 2017

Coverage Status

Coverage remained the same at 51.752% when pulling 3b78d8e on frankgasking:soundpyo-patch into 5029631 on psychopy:master.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 7, 2017

Codecov Report

Merging #1365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   47.33%   47.33%           
=======================================
  Files         237      237           
  Lines       37357    37357           
  Branches     5796     5796           
=======================================
  Hits        17684    17684           
  Misses      18026    18026           
  Partials     1647     1647

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5029631...3b78d8e. Read the comment docs.

@peircej peircej merged commit ca5e44c into psychopy:master Mar 8, 2017
2 checks passed
2 checks passed
code-quality/landscape Code quality remained the same
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants