New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Add status attribute in CedrusBox script generation #1493

Merged
merged 1 commit into from Aug 26, 2017

Conversation

Projects
None yet
3 participants
@armanfarhangi
Contributor

armanfarhangi commented Aug 25, 2017

Attempting to utilize a cedrusButtonBox response in the Builder view results in the error:

AttributeError: 'ResponseDevice' object has no attribute 'status'

Unlike classes like KeyBoardComponent, cedrusButtonBoxComponent does not have a corresponding response class in which the status attribute is initialized. However, the status attribute is still necessary for the experiment script to run, hence the changes.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 25, 2017

Codecov Report

Merging #1493 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1493   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         249      249           
  Lines       39614    39614           
  Branches     5983     5983           
=======================================
  Hits        19741    19741           
  Misses      18124    18124           
  Partials     1749     1749
Impacted Files Coverage Δ
...chopy/app/builder/components/cedrusBox/__init__.py 63.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6664aa...8a85870. Read the comment docs.

@peircej peircej merged commit fb1c573 into psychopy:master Aug 26, 2017

2 checks passed

code-quality/landscape Code quality remained the same
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peircej

This comment has been minimized.

Member

peircej commented Aug 26, 2017

Your indentation was broken in that change. I've pulled it in anyway and fixed the indentation in 9fb5dd9

Try to write/edit python code using an editor that is Python-aware (Spyder and PyCharm CE are both excellent free options). If you use a simpler editor, make sure that it is at least inserting 4 spaces instead of tab characters - that's what nearly all python programmers do. Your commit ended up with mixed tabs and spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment