New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: psychopy updates shouldn't suggest 'updating' to older version #1567

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@martharobinson
Contributor

martharobinson commented Oct 18, 2017

This addresses issue #1443 , which I think was a twofold issue. The first was a simple bug in connections.py, where the latest version isn't expanded properly when checking if the install is up-to-date.

The second is that self.latest is fetched from http://www.psychopy.org/version.txt, which at the moment is 1.85.3. There was no handling for when the running version is actually higher than this. I'm not sure if this is a situation that is intended to happen, or if the version.txt page is just out of date. The intstallation instructions recommend installing 1.85.4.

I've added some handling so that the message "You are running PsychoPy ([VERSION]), which is ahead of the latest official version ([VERSION])" is displayed when this occurs. It may be that the version.txt page should also be updated.

@coveralls

This comment has been minimized.

coveralls commented Oct 18, 2017

Coverage Status

Coverage increased (+0.002%) to 54.627% when pulling 1026968 on martharobinson:issue1443 into 9bf5088 on psychopy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 18, 2017

Codecov Report

Merging #1567 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   50.25%   50.25%   +<.01%     
==========================================
  Files         254      254              
  Lines       40471    40473       +2     
  Branches     6062     6063       +1     
==========================================
+ Hits        20337    20339       +2     
  Misses      18367    18367              
  Partials     1767     1767
Impacted Files Coverage Δ
psychopy/app/connections.py 16% <0%> (-0.08%) ⬇️
psychopy/tests/test_misc/test_core.py 81.33% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf5088...1026968. Read the comment docs.

@peircej

This comment has been minimized.

Member

peircej commented Oct 18, 2017

Yes, the possibility to run versions newer than the one listed in http://www.psychopy.org/version.txt should be made possible. version.txt should always give the latest recommended version and with some releases (particularly X.X.0 releases) I don't recommend upgrading to most users.

@peircej peircej merged commit 55ef2b9 into psychopy:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

peircej added a commit to peircej/psychopy that referenced this pull request Nov 21, 2017

ENH: use parse version in version checking of psychopy itself
closes psychopy#1443

A further safety check for version comparison. The main fix had
already been provided in psychopy#1567 but this adds the extra security
of using `parse_version()`. '1.90.0a1' is > '1.90.0' al[habetically
but in version syntax would be the preceding alpha release (i.e.
should be considered less than 1.90.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment