New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: incorrect units in images_blocks Builder demo #1601

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
4 participants
@m-macaskill
Contributor

m-macaskill commented Nov 27, 2017

Changed image stimulus units from pix to height so that the image stimuli display correctly (with a size of (0.5, 0.5), they were invisible with pixel units).

BF: images_blocks Builder demo incorrect units
Changed image units from pixels to height so that the image stimuli display (with a size of (0.5, 0.5), they were invisible with pixel units).
@coveralls

This comment has been minimized.

coveralls commented Nov 27, 2017

Coverage Status

Coverage remained the same at 49.448% when pulling 10753d7 on m-macaskill_images_blocks_demo into 2d1fcaa on master.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 27, 2017

Codecov Report

Merging #1601 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   44.91%   44.91%   +<.01%     
==========================================
  Files         205      205              
  Lines       34406    34406              
  Branches     5390     5390              
==========================================
+ Hits        15454    15455       +1     
  Misses      17395    17395              
+ Partials     1557     1556       -1
Impacted Files Coverage Δ
psychopy/tools/wizard.py 74.29% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d1fcaa...10753d7. Read the comment docs.

@peircej peircej merged commit bf057f5 into master Nov 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-macaskill m-macaskill deleted the m-macaskill_images_blocks_demo branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment