BF: fix pyoSndServer hanging #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update base
Using atexit we can properly shutdown pyoSndServer upon clean up, preventing the program from hanging.
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 44.98% 44.97% -0.01%
==========================================
Files 205 205
Lines 34405 34408 +3
Branches 5396 5396
==========================================
- Hits 15477 15476 -1
- Misses 17364 17367 +3
- Partials 1564 1565 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using microphone with pyo backend would cause python to hang upon closing because it would be waiting for the sndServer to close. Using atexit, we can tell pyoSndServer to close out, thus resolving this issue.
fixes #677