Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix pyoSndServer hanging #1614

Merged
merged 2 commits into from Dec 6, 2017

Conversation

@CRiddler
Copy link
Contributor

@CRiddler CRiddler commented Dec 6, 2017

Using microphone with pyo backend would cause python to hang upon closing because it would be waiting for the sndServer to close. Using atexit, we can tell pyoSndServer to close out, thus resolving this issue.

fixes #677

CRiddler added 2 commits Dec 6, 2017
Using atexit we can properly shutdown pyoSndServer upon clean up, preventing the program from hanging.
@coveralls
Copy link

@coveralls coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-0.004%) to 49.532% when pulling 7fd7843 on CRiddler:CRiddler-fix_pyoSndServer_hang into c803407 on psychopy:master.

2 similar comments
@coveralls
Copy link

@coveralls coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-0.004%) to 49.532% when pulling 7fd7843 on CRiddler:CRiddler-fix_pyoSndServer_hang into c803407 on psychopy:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-0.004%) to 49.532% when pulling 7fd7843 on CRiddler:CRiddler-fix_pyoSndServer_hang into c803407 on psychopy:master.

@peircej peircej merged commit 6c3de6f into psychopy:master Dec 6, 2017
1 check passed
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 6, 2017

Codecov Report

Merging #1614 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
- Coverage   44.98%   44.97%   -0.01%     
==========================================
  Files         205      205              
  Lines       34405    34408       +3     
  Branches     5396     5396              
==========================================
- Hits        15477    15476       -1     
- Misses      17364    17367       +3     
- Partials     1564     1565       +1
Impacted Files Coverage Δ
psychopy/sound/backend_pyo.py 0% <0%> (ø) ⬆️
psychopy/tools/wizard.py 73.42% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c803407...7fd7843. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants