Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Ok button overriding saved prefs after Apply clicked. #1832

Merged
merged 1 commit into from
May 24, 2018

Conversation

dvbridges
Copy link
Contributor

If changes were made to audio devices in the prefs dlg, the preferences were overwritten by previous preferences when the apply button was used followed by Ok button. No other selections seem to be affected by this bug. Solution: remove redundant 'Apply' button.

If changes were made to audio devices in the prefs dlg, the preferences were overwritten by previous preferences when the apply button was used followed by Ok button. No other selections seem to be affected by this bug. Solution: remove redundant 'Apply' button.
@dvbridges dvbridges changed the title BF: Ok button overriding saves prefs when Apply clicked. BF: Ok button overriding saved prefs after Apply clicked. May 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #1832 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
+ Coverage   46.96%   46.97%   +<.01%     
==========================================
  Files         219      219              
  Lines       33483    33477       -6     
  Branches     5611     5611              
==========================================
  Hits        15725    15725              
+ Misses      16197    16191       -6     
  Partials     1561     1561
Impacted Files Coverage Δ
psychopy/app/preferencesDlg.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55945a5...567fb3b. Read the comment docs.

@peircej peircej merged commit 7629044 into psychopy:master May 24, 2018
@dvbridges dvbridges deleted the prefsFix branch August 30, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants