Slider is ready for testing #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets both the fill and line if used
features: - far fewer params - Supports vertical and horizontal - more efficient rendering (e.g. element array for tickLines) - customise attributes (line, marker...) after creation - option for us to create some "styles" with customised line/marker objects - if user wants keyboard resp they can control self.rating themselves to do: - use precision setting - render text labels
Labels respect horiz/vert and flip=True/False. They don't know how to auto-space themselves yet The granularity appears to work fine
Also fixed RT record
... about unknown color space
Which means we no longer need a customize option
We've added list and fixedList data types. For an interpreter these can be treated identically but for PsychoPy a fixedList means that we know in advance what entries are allowed (so we can use CheckListBox to present the options rather than requiring the user to correctly format plain text).
# Conflicts: # psychopy/tests/test_app/test_builder/componsTemplate.txt
Codecov Report
@@ Coverage Diff @@
## master #1836 +/- ##
==========================================
- Coverage 46.96% 46.74% -0.22%
==========================================
Files 219 221 +2
Lines 33485 33830 +345
Branches 5612 5674 +62
==========================================
+ Hits 15725 15813 +88
- Misses 16197 16448 +251
- Partials 1563 1569 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs documentation though! (The Builder demo give the best example of use)