New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fixes refcount issue with monitor centre. Fixes #1827. #1838

Merged
merged 1 commit into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@dvbridges
Contributor

dvbridges commented May 25, 2018

In monitor center, the SimpleGrid class needs to increment the refcount when the refcounted object, in this case the GridCellFloatEditor, is assigned to multiple objects, in this case the cell editor objects that exist in the grid cell. See wxWidgets/Phoenix#627 for explanation. Fixes #1827.

David Bridges David Bridges
BF: Fixes refcount issue with monitor centre. Fixes #1827.
In monitor center, the SimpleGrid class needs to increment the refcount when the refcounted object, in this case the GridCellFloatEditor, is assigned to multiple objects, in this case the cell editor objects that exist in the grid cell. See wxWidgets/Phoenix#627 for explanation. Fixes #1827.
@codecov-io

This comment has been minimized.

codecov-io commented May 25, 2018

Codecov Report

Merging #1838 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage   46.73%   46.74%   +<.01%     
==========================================
  Files         221      221              
  Lines       33830    33831       +1     
  Branches     5674     5674              
==========================================
+ Hits        15811    15814       +3     
  Misses      16449    16449              
+ Partials     1570     1568       -2
Impacted Files Coverage Δ
psychopy/monitors/MonitorCenter.py 0% <0%> (ø) ⬆️
psychopy/visual/textbox/fontmanager.py 69.96% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab9072...0ef1894. Read the comment docs.

@peircej

This comment has been minimized.

peircej commented on 0ef1894 Jun 1, 2018

wow, well done for tracking that tricky one down! ;-)

@peircej peircej merged commit 2e60910 into psychopy:master Jun 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@dvbridges dvbridges deleted the dvbridges:refCountError branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment