New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Builder variables should not be used as the column name in condit… #1852

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
3 participants
@hsogo
Contributor

hsogo commented Jun 12, 2018

Builder variables can be used as the column name in conditions file, which can cause annoying problems. For example, using filename in the condition file as following, name of output files are overwritten.

3

I think that Builder must check whether Builder variables are included in the column names of conditions file.

@coveralls

This comment has been minimized.

coveralls commented Jun 12, 2018

Coverage Status

Coverage decreased (-0.1%) to 50.034% when pulling 0f40aa8 on hsogo:master into 00adb8c on psychopy:master.

@peircej peircej merged commit d6cb9a8 into psychopy:master Jun 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
LGTM analysis: Python No alert changes
Details
@peircej

This comment has been minimized.

Member

peircej commented Jun 12, 2018

The build appeared to fail only on the badly outdated system python installation. (It's time we shut that one down I think.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment