New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Amendments to JP fix to getRegionOfFrame - now working #1854

Merged
merged 5 commits into from Jun 18, 2018

Conversation

Projects
None yet
4 participants
@dvbridges
Contributor

dvbridges commented Jun 14, 2018

Note, getpixel from the returned image object does not work if back buffer is used, or if full screen is used.

peircej and others added some commits Jun 13, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jun 18, 2018

Codecov Report

Merging #1854 into master will decrease coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
- Coverage   45.64%   45.64%   -0.01%     
==========================================
  Files         221      221              
  Lines       35174    35168       -6     
  Branches     5864     5864              
==========================================
- Hits        16054    16051       -3     
+ Misses      17541    17539       -2     
+ Partials     1579     1578       -1
Impacted Files Coverage Δ
psychopy/visual/window.py 70.74% <93.75%> (-0.24%) ⬇️
psychopy/tools/wizard.py 74.45% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cb9a8...2457eb2. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Jun 18, 2018

Coverage Status

Coverage decreased (-0.003%) to 50.125% when pulling 2457eb2 on dvbridges:gePixelFromFrame into d6cb9a8 on psychopy:master.

@peircej

This comment has been minimized.

Member

peircej commented Jun 18, 2018

But it looks like you're saying that accepting this change means that we're no longer able to fetch from the back buffer? We do need to be able to do that. We can't just turn off uses of the back-buffer; there are times when it's important to be able to exam pixels before a flip command.

@dvbridges

This comment has been minimized.

Contributor

dvbridges commented Jun 18, 2018

I dont think I have made any changes that stop you from fetching from the back buffer. I was just saying that if you do try to use the back buffer, the buffered image does not seem to hold all the components, only the background image. So, when you try to get specific pixels from the back buffer, you cannot get pixels from visual components, such as shape, as they do not appear on the back buffered image.

@peircej

This comment has been minimized.

Member

peircej commented Jun 18, 2018

Ah, you're meaning from a Builder experiment? That's fine, yes the issue is that all stimuli that have been rendered (with .draw() ) should show up in the back buffer, but stimuli rendered using autoDraw=True (as in a Builder experiment) are only rendered when win.flip() is called. So if you grab the backbuffer before win.flip() then yes, visual builder components won't show up. Then again, if you grab it with buffer='front' then you're effectively getting the contents of the previous frame, not the current one.

@dvbridges

This comment has been minimized.

Contributor

dvbridges commented Jun 18, 2018

Great thanks. So, should we draw to back buffer if _getFrame is requested with buffer='back'?

@peircej

This comment has been minimized.

Member

peircej commented Jun 18, 2018

should we draw to back buffer if _getFrame is requested with buffer='back'?

I don't follow. Can chat tomorrow though

@dvbridges

This comment has been minimized.

Contributor

dvbridges commented Jun 18, 2018

Ok, as this request is ok for now, would you mind merging with master?

@peircej peircej merged commit 857c491 into psychopy:master Jun 18, 2018

2 checks passed

LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dvbridges dvbridges deleted the dvbridges:gePixelFromFrame branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment