New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow Slider dragging outside of "valid" area #1945

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
4 participants
@hoechenberger
Member

hoechenberger commented Aug 15, 2018

With a slider I commonly expect that, once I have started dragging, I can move the mouse cursor away from the slider while dragging continues (and the slider updates accordingly). This commit adds this feature.

ENH: Allow Slider dragging outside of "valid" area
With a slider I commonly expect that, once I have started dragging, I
can move the mouse cursor away from the slider while dragging continues
(and the slider updates accordingly). This commit adds this feature.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 15, 2018

Codecov Report

Merging #1945 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   43.88%   43.88%   -0.01%     
==========================================
  Files         207      207              
  Lines       36360    36360              
  Branches     6214     6214              
==========================================
- Hits        15958    15955       -3     
- Misses      18853    18858       +5     
+ Partials     1549     1547       -2
Impacted Files Coverage Δ
psychopy/visual/slider.py 16.15% <0%> (ø) ⬆️
psychopy/visual/textbox/fontmanager.py 70.03% <0%> (-1.05%) ⬇️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/builder/builder.py 51.72% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a800...a5f2e2c. Read the comment docs.

codecov-io commented Aug 15, 2018

Codecov Report

Merging #1945 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   43.88%   43.88%   -0.01%     
==========================================
  Files         207      207              
  Lines       36360    36360              
  Branches     6214     6214              
==========================================
- Hits        15958    15955       -3     
- Misses      18853    18858       +5     
+ Partials     1549     1547       -2
Impacted Files Coverage Δ
psychopy/visual/slider.py 16.15% <0%> (ø) ⬆️
psychopy/visual/textbox/fontmanager.py 70.03% <0%> (-1.05%) ⬇️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/builder/builder.py 51.72% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a800...a5f2e2c. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 15, 2018

Coverage Status

Coverage decreased (-0.003%) to 48.158% when pulling a5f2e2c on hoechenberger:dragging into 029a800 on psychopy:master.

coveralls commented Aug 15, 2018

Coverage Status

Coverage decreased (-0.003%) to 48.158% when pulling a5f2e2c on hoechenberger:dragging into 029a800 on psychopy:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 15, 2018

Coverage Status

Coverage decreased (-0.003%) to 48.158% when pulling a5f2e2c on hoechenberger:dragging into 029a800 on psychopy:master.

coveralls commented Aug 15, 2018

Coverage Status

Coverage decreased (-0.003%) to 48.158% when pulling a5f2e2c on hoechenberger:dragging into 029a800 on psychopy:master.

@peircej

This comment has been minimized.

Show comment
Hide comment
@peircej

peircej Aug 15, 2018

Member

That's good point. And what an easy fix! :-)

Member

peircej commented Aug 15, 2018

That's good point. And what an easy fix! :-)

@peircej peircej merged commit 3b684fa into psychopy:master Aug 15, 2018

1 of 2 checks passed

LGTM analysis: Python Running analyses for revisions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hoechenberger hoechenberger deleted the hoechenberger:dragging branch Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment