New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to a bug related to static component #2124

Merged
merged 1 commit into from Dec 3, 2018
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

Fix a bug

`bytes(compName)` does not work in Python 3 and because of that static component does not work too.
replacing it by `str(compName)` fixed the problem
  • Loading branch information...
PanBartosz committed Dec 2, 2018
commit 835a947c1e7a942a5968f35bf978fb73d527f13e
@@ -156,7 +156,7 @@ def writeParamUpdates(self, buff, updateType=None, paramNames=None):
prms = compName.params # it's already a compon so get params
else:
# it's a name so get compon and then get params
prms = self.exp.getComponentFromName(bytes(compName)).params
prms = self.exp.getComponentFromName(str(compName)).params
self.writeParamUpdate(buff, compName=compName,
paramName=fieldName,
val=prms[fieldName],
ProTip! Use n and p to navigate between commits in a pull request.