New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Sound files were not ending online if duration was None. #2274

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@dvbridges
Copy link
Contributor

dvbridges commented Feb 11, 2019

This fix now checks the duration of each sound file (if sound file used)
and stops the sounds after that duration. Also, sound component status are
updated now. Also, tones and frequencies are now handled specifically
because they do not have a predetermined duration like a sound file.

BF: Sound files were not ending online if duration was None.
This fix now checks the duration of each sound file (if sound file used)
and stops the sounds after that duration. Also, sound component status are
updated now. Also, tones and frequencies are now handled specifically
because they do not have a predetermined duration like a sound file.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #2274 into master will decrease coverage by 0.01%.
The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
- Coverage   42.91%   42.89%   -0.02%     
==========================================
  Files         221      221              
  Lines       38487    38493       +6     
  Branches     6642     6643       +1     
==========================================
- Hits        16517    16513       -4     
- Misses      20403    20411       +8     
- Partials     1567     1569       +2
Impacted Files Coverage Δ
psychopy/experiment/components/sound/__init__.py 44.64% <5.55%> (-1.59%) ⬇️
psychopy/data/base.py 73.36% <0%> (-0.88%) ⬇️
psychopy/visual/window.py 67.06% <0%> (-0.73%) ⬇️
psychopy/app/connections/news.py 53.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08038d1...611e62c. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage decreased (-0.02%) to 46.975% when pulling 611e62c on dvbridges:soundFix into 08038d1 on psychopy:master.

@peircej peircej merged commit 4a576eb into psychopy:master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment