BF: Keyboard event keys cleared properly#2442
Merged
peircej merged 1 commit intopsychopy:masterfrom May 9, 2019
Merged
Conversation
KB was calling clearEvents, which only cleared the events list, not the actual list of keys pressed. This means that keypresses persisted even the option to discard previous keypresses before KB onset was selected. To fix, rather than have clearEvents call _clearEvents, which other methods also call, the events and key list are cleared directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KB was calling clearEvents to clear the key buffer, which only cleared the events list, not the
actual list of keys pressed. This means that keypresses persisted
even with the option to discard previous keypresses before KB onset
was selected. To fix, rather than have clearEvents call _clearEvents,
which other methods also call, the events and key list are cleared
directly.