Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Keyboard event keys cleared properly #2442

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
3 participants
@dvbridges
Copy link
Contributor

commented May 8, 2019

KB was calling clearEvents to clear the key buffer, which only cleared the events list, not the
actual list of keys pressed. This means that keypresses persisted
even with the option to discard previous keypresses before KB onset
was selected. To fix, rather than have clearEvents call _clearEvents,
which other methods also call, the events and key list are cleared
directly.

BF: Keyboard event keys cleared properly
KB was calling clearEvents, which only cleared the events list, not the
actual list of keys pressed. This means that keypresses persisted
even the option to discard previous keypresses before KB onset
 was selected. To fix, rather than have clearEvents call _clearEvents,
which other methods also call, the events and key list are cleared
 directly.
@coveralls

This comment has been minimized.

Copy link

commented May 8, 2019

Coverage Status

Coverage increased (+3.0e-05%) to 49.335% when pulling ed1cde1 on dvbridges:kbClearFix into 63e05e4 on psychopy:master.

@peircej peircej merged commit 11f9198 into psychopy:master May 9, 2019

2 checks passed

LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dvbridges dvbridges deleted the dvbridges:kbClearFix branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.