Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Find and save orphaned data at end of online task #2496

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
4 participants
@dvbridges
Copy link
Contributor

commented Jun 18, 2019

This fix solves a problem where routine data was not saved
if no loops came after that routine (because nextEntry was not called).

This current implementation will not work until PsychoJS
Experiment Handler attributes of _trialsData and thisCurrentTrial
are changed to entries and thisEntry, respectively.

BF: Find and save orphaned data at end of experiment
This fix solves a problem where routine data was not saved
if no loops came after that routine (because nextEntry was not called).

This current implementation will not work until PsychoJS
Experiment Handler attributes of `_trialsData` and 'thisCurrentTrial`
are changed  to `entries` and `thisEntry`, respectively.
@codecov-io

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #2496 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
+ Coverage   44.66%   44.67%   +<.01%     
==========================================
  Files         232      232              
  Lines       40254    40254              
  Branches     6914     6914              
==========================================
+ Hits        17981    17983       +2     
+ Misses      20413    20411       -2     
  Partials     1860     1860
Impacted Files Coverage Δ
...sychopy/experiment/components/settings/__init__.py 76.11% <ø> (ø) ⬆️
psychopy/visual/textbox/fontmanager.py 71.08% <0%> (-0.7%) ⬇️
psychopy/tools/wizard.py 73.3% <0%> (-0.44%) ⬇️
psychopy/visual/window.py 66.51% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6834f61...5507d9c. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Jun 18, 2019

Coverage Status

Coverage increased (+0.005%) to 49.311% when pulling 5507d9c on dvbridges:getOrphanedData into 6834f61 on psychopy:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Jun 18, 2019

Coverage Status

Coverage increased (+0.005%) to 49.311% when pulling 5507d9c on dvbridges:getOrphanedData into 6834f61 on psychopy:master.

@peircej peircej merged commit 83ad39a into psychopy:master Jun 18, 2019

2 checks passed

LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dvbridges dvbridges deleted the dvbridges:getOrphanedData branch Jun 18, 2019

@dvbridges dvbridges restored the dvbridges:getOrphanedData branch Jun 19, 2019

@dvbridges

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@peircej , another situation has arisen where data not being saved. In a nested loop, with the outerloop isTrials is False, and the inner loop isTrials is True, a participant ending their inner loop on the first iteration, but repeats inner loop n times based on number of trials in the outerloop, will not have data saved. This is because breaking the inner loop on the first iteration does not call nextExtry(), and the outer loop where isTrials is False does not call nextEntry(). Calling at the end of the task will only write the last trial recorded. The solution is to call nextEntry in endLoopIteration() when currentLoop is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.