Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mic #2512

Merged
merged 3 commits into from Jul 3, 2019
Merged

Fix mic #2512

merged 3 commits into from Jul 3, 2019

Conversation

peircej
Copy link
Member

@peircej peircej commented Jul 3, 2019

No description provided.

peircej and others added 3 commits Jun 25, 2019
Actually 3 changes:

1. although we had updated the new default we hadn't forced old experiments
   to use the new format so they still gave error that channel is wrong type
2. it was set to be valTypoe='int' whereas 'code' is
   marginally better (works either way unless a variable is used and then
   only 'code' works)
3. Also added a change to the AudioCapture class to detect and auto-convert
   if possible so that existing *scripts* would also work correctly
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 3, 2019

Codecov Report

Merging #2512 into master will decrease coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage    44.5%   44.49%   -0.01%     
==========================================
  Files         232      232              
  Lines       40261    40269       +8     
  Branches     6917     6919       +2     
==========================================
  Hits        17919    17919              
- Misses      20446    20458      +12     
+ Partials     1896     1892       -4
Impacted Files Coverage Δ
psychopy/experiment/_experiment.py 50.85% <0%> (-0.3%) ⬇️
psychopy/microphone.py 35.29% <0%> (-0.31%) ⬇️
...chopy/experiment/components/microphone/__init__.py 91.37% <100%> (ø) ⬆️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/dialogs.py 27.68% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️
...ychopy/localization/generateTranslationTemplate.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e50c5...91d5950. Read the comment docs.

@coveralls
Copy link

@coveralls coveralls commented Jul 3, 2019

Coverage Status

Coverage decreased (-0.007%) to 49.216% when pulling 91d5950 on peircej:fix-mic into 60e50c5 on psychopy:master.

@peircej peircej merged commit fbce22f into psychopy:master Jul 3, 2019
1 of 2 checks passed
@peircej peircej deleted the fix-mic branch Jul 3, 2019
@peircej
Copy link
Member Author

@peircej peircej commented Jul 3, 2019

This pull request introduces 1 alert and fixes 1 when merging 91d5950 into 60e50c5 - view on LGTM.com

new alerts:

  • 1 for Non-callable called

fixed alerts:

  • 1 for Non-callable called

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants