Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Print errors to stdoutFrame #2594

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@dvbridges
Copy link
Contributor

commented Sep 2, 2019

Trackback error messages were starting on the StdOutFrame and finishing
on the console. Also, an error occured randomly causing psychopy to crash.
The crash would happen when printing whilst a traceback was printed.
With this fix, the crash has not reoccurred.

Trackback error messages were starting on the StdOutFrame and finishing
on the console. Also, an error occured randomly causing psychopy to crash.
The crash would happen when printing whilst a traceback was printed.
With this fix, the crash has not reoccurred.
@coveralls

This comment has been minimized.

Copy link

commented Sep 2, 2019

Coverage Status

Coverage decreased (-0.005%) to 48.925% when pulling 812efbb on dvbridges:printErrors into 55b2a41 on psychopy:master.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #2594 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
- Coverage   44.21%   44.19%   -0.03%     
==========================================
  Files         234      234              
  Lines       41597    41599       +2     
  Branches     7192     7193       +1     
==========================================
- Hits        18394    18386       -8     
- Misses      21240    21247       +7     
- Partials     1963     1966       +3
Impacted Files Coverage Δ
psychopy/app/builder/builder.py 49.72% <0%> (-0.07%) ⬇️
psychopy/data/base.py 73.36% <0%> (-0.88%) ⬇️
psychopy/visual/window.py 66.43% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b2a41...812efbb. Read the comment docs.

@peircej peircej merged commit f864731 into psychopy:master Sep 4, 2019
2 checks passed
2 checks passed
LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.