BF: Make subprocess.Popen params Py2 and Py3 compatible #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2596 +/- ##
=======================================
Coverage 44.21% 44.21%
=======================================
Files 234 234
Lines 41597 41597
Branches 7192 7192
=======================================
Hits 18394 18394
Misses 21240 21240
Partials 1963 1963
Continue to review full report at Codecov.
|
Splitting the string for the args param in subprocess was causing filenames with spaces to be split at the space. This fix creates the list of strings of required commands so no string split method is needed. Part fix for https://discourse.psychopy.org/t/new-release-3-2-0/8931/7
|
This pull request fixes 1 alert when merging bf4d670 into 55b2a41 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part fix for #2595