Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
BF: Make subprocess.Popen params Py2 and Py3 compatible #2596
@@ Coverage Diff @@ ## master #2596 +/- ## ======================================= Coverage 44.21% 44.21% ======================================= Files 234 234 Lines 41597 41597 Branches 7192 7192 ======================================= Hits 18394 18394 Misses 21240 21240 Partials 1963 1963
Splitting the string for the args param in subprocess was causing filenames with spaces to be split at the space. This fix creates the list of strings of required commands so no string split method is needed. Part fix for https://discourse.psychopy.org/t/new-release-3-2-0/8931/7
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.