Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Make subprocess.Popen params Py2 and Py3 compatible #2596

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@dvbridges
Copy link
Contributor

commented Sep 3, 2019

Part fix for #2595

Part fix for #2595
@coveralls

This comment has been minimized.

Copy link

commented Sep 3, 2019

Coverage Status

Coverage increased (+0.01%) to 48.939% when pulling bf4d670 on dvbridges:subprocessFix into 55b2a41 on psychopy:master.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #2596 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2596   +/-   ##
=======================================
  Coverage   44.21%   44.21%           
=======================================
  Files         234      234           
  Lines       41597    41597           
  Branches     7192     7192           
=======================================
  Hits        18394    18394           
  Misses      21240    21240           
  Partials     1963     1963
Impacted Files Coverage Δ
psychopy/app/builder/builder.py 49.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b2a41...bf4d670. Read the comment docs.

Splitting the string for the args param in subprocess was causing filenames
with spaces to be split at the space. This fix creates the list of
strings of required commands so no string split method is needed. Part fix
for https://discourse.psychopy.org/t/new-release-3-2-0/8931/7
@peircej peircej merged commit 4d9ca7c into psychopy:master Sep 3, 2019
2 checks passed
2 checks passed
LGTM analysis: Python 1 fixed alert
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lgtm-com

This comment has been minimized.

Copy link

commented Sep 3, 2019

This pull request fixes 1 alert when merging bf4d670 into 55b2a41 - view on LGTM.com

fixed alerts:

  • 1 for Wrong name for an argument in a class instantiation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.