Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: compilation fails if allowedKeys for Cedrus Box are a variable #2608

Merged
merged 3 commits into from Sep 10, 2019

Conversation

@alexander-pastukhov
Copy link
Contributor

commented Sep 9, 2019

In Builder, when using a variable for allowedKeys of CedrusBox component, the compilation would fail. Code generation now uses same code style as keyboard component.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #2608 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   44.36%   44.35%   -0.01%     
==========================================
  Files         234      234              
  Lines       41606    41608       +2     
  Branches     7196     7196              
==========================================
- Hits        18457    18454       -3     
  Misses      21185    21185              
- Partials     1964     1969       +5
Impacted Files Coverage Δ
...ychopy/experiment/components/cedrusBox/__init__.py 65.28% <16.66%> (-0.26%) ⬇️
psychopy/visual/window.py 66.47% <0%> (-0.69%) ⬇️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️
...ychopy/localization/generateTranslationTemplate.py 0% <0%> (ø) ⬆️
psychopy/tools/wizard.py 73.74% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a61140...c13dc1d. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #2608 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   44.36%   44.35%   -0.01%     
==========================================
  Files         234      234              
  Lines       41606    41608       +2     
  Branches     7196     7196              
==========================================
- Hits        18457    18454       -3     
  Misses      21185    21185              
- Partials     1964     1969       +5
Impacted Files Coverage Δ
...ychopy/experiment/components/cedrusBox/__init__.py 65.28% <16.66%> (-0.26%) ⬇️
psychopy/visual/window.py 66.47% <0%> (-0.69%) ⬇️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️
...ychopy/localization/generateTranslationTemplate.py 0% <0%> (ø) ⬆️
psychopy/tools/wizard.py 73.74% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a61140...c13dc1d. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Sep 9, 2019

Coverage Status

Coverage increased (+0.02%) to 49.085% when pulling c13dc1d on alexander-pastukhov:master into 2a61140 on psychopy:master.

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 9, 2019

This pull request fixes 1 alert when merging c13dc1d into 2a61140 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
@peircej peircej merged commit a9d5fd3 into psychopy:master Sep 10, 2019
2 checks passed
2 checks passed
LGTM analysis: Python 1 fixed alert
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.