Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: QuestPlusHandler now accepts "unknown" kwargs #2610

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@hoechenberger
Copy link
Member

commented Sep 10, 2019

This is necessary e.g. when QuestPlusHandlers are created via a MultiStairHandler, and all "MultiStair conditions" are passed down to QuestPlusHandler. These are now all swallowed through a **kwarg in the signature. To warn users of potential typos in their code, a warning will be emitted if one or more unknown kwargs are encountered.

This is necessary e.g. when QuestPlusHandlers are created via a
MultiStairHandler, and all "MultiStair conditions" are passed down to
QuestPlusHandler. These are now all swallowed through a **kwarg in the
signature. To warn users of potential typos in their code, a warning
will be emitted if one or more unknown kwargs are encountered.
@coveralls

This comment has been minimized.

Copy link

commented Sep 10, 2019

Coverage Status

Coverage increased (+0.01%) to 49.095% when pulling 8c1f999 on hoechenberger:qp into a9d5fd3 on psychopy:master.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #2610 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
+ Coverage   44.34%   44.36%   +0.01%     
==========================================
  Files         234      234              
  Lines       41608    41616       +8     
  Branches     7196     7198       +2     
==========================================
+ Hits        18452    18462      +10     
- Misses      21186    21189       +3     
+ Partials     1970     1965       -5
Impacted Files Coverage Δ
psychopy/data/staircase.py 65.25% <100%> (+0.44%) ⬆️
psychopy/visual/textbox/__init__.py 43.5% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️
...ychopy/localization/generateTranslationTemplate.py 0% <0%> (ø) ⬆️
psychopy/tools/wizard.py 73.74% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d5fd3...8c1f999. Read the comment docs.

@peircej peircej merged commit b716a7d into psychopy:master Sep 11, 2019
2 checks passed
2 checks passed
LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hoechenberger hoechenberger deleted the hoechenberger:qp branch Sep 11, 2019
@hoechenberger

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

@peircej Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.