BF: QuestPlusHandler now accepts "unknown" kwargs #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary e.g. when QuestPlusHandlers are created via a MultiStairHandler, and all "MultiStair conditions" are passed down to QuestPlusHandler. These are now all swallowed through a **kwarg in the signature. To warn users of potential typos in their code, a warning will be emitted if one or more unknown kwargs are encountered.
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
+ Coverage 44.34% 44.36% +0.01%
==========================================
Files 234 234
Lines 41608 41616 +8
Branches 7196 7198 +2
==========================================
+ Hits 18452 18462 +10
- Misses 21186 21189 +3
+ Partials 1970 1965 -5
Continue to review full report at Codecov.
|
|
@peircej Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary e.g. when
QuestPlusHandlersare created via aMultiStairHandler, and all "MultiStair conditions" are passed down toQuestPlusHandler. These are now all swallowed through a**kwargin the signature. To warn users of potential typos in their code, a warning will be emitted if one or more unknown kwargs are encountered.