Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Have attributes width and height aliased with size in RectStim. #2650

Merged
merged 3 commits into from
Oct 15, 2019
Merged

RF: Have attributes width and height aliased with size in RectStim. #2650

merged 3 commits into from
Oct 15, 2019

Conversation

mdcutone
Copy link
Member

Fixes issue #2644 by aliasing width and height with size.

Behavior of __init__ has been changed to use size only to set the dimensions of the rectangle. Keyword arguments width and height set size. If size is specified, the values of width and height are ignored. Documentation has been updated to reveal this new behavior. Attributes width and height can be set after initialization so operations may be used to manipulate the shape of the rectangle in one dimension. Changing the size attribute will also update the values of width and height.

@mdcutone mdcutone changed the title RF: Have attributes width and height aliased with size. RF: Have attributes width and height aliased with size in RectStim. Oct 14, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2019

This pull request fixes 2 alerts when merging b7c14a2 into 8db8521 - view on LGTM.com

fixed alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2019

This pull request fixes 2 alerts when merging 9830151 into 8db8521 - view on LGTM.com

fixed alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@peircej peircej merged commit b446c24 into psychopy:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants